Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding latency/bandwidth configuration through .toml files #57

Merged
merged 5 commits into from
Sep 2, 2022

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Aug 29, 2022

This gives us more flexibility in test-case development as now, we can configure latency and bandwidth in .toml files
A pre-requisite for setting up a network

Related to Test-Plan-001
Should be reviewed after #56
Closes #52
Ref: #55

Move the creation of a validator to the common dir
Adjusted the init-validator case to accept the pers-peers param
Move home path to app struct to eliminate passing home var to all methods
@Bidon15 Bidon15 added enhancement New feature or request testground related to testground labels Aug 29, 2022
@Bidon15 Bidon15 self-assigned this Aug 29, 2022
@Bidon15 Bidon15 marked this pull request as ready for review August 30, 2022 08:51
@Bidon15 Bidon15 requested review from Wondertan, renaynay and vgonkivs and removed request for Wondertan August 30, 2022 08:51
Bidon15 and others added 2 commits August 30, 2022 11:44
Co-authored-by: Viacheslav Gonkivskyi <[email protected]>
This gives us more flexibility in test-case development
Related to Test-Plan celestiaorg#1
Copy link
Member

@vgonkivs vgonkivs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Parametrize everything.
(I wish we would have even more things parametrized tbh)

@Bidon15 Bidon15 merged commit 19a87ce into celestiaorg:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testground related to testground
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

testground: bandwidth params as manifest.toml test values
3 participants